Changing Share Permissions with Powershell / SUBINACL

I'm trying to set share permissions with the script below, but nothing seems to happen when I run the script.

$User="testuser"

function SetSharePerm
{
   $shareName="\\acmeserv1\users$\$user"
   $userName="acme\$user"
   $SUBINACL='C:\Program Files (x86)\Windows Resource Kits\Tools\subinacl.exe'
   &$SUBINACL /share $shareName /grant="acme\Domain Admins"=F /grant=$userName=C |Out-Null

   }
 SetSharePerm -user $user

Open in new window


What am I doing wrong?
Tim BallinAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Adam BrownSr Solutions ArchitectCommented:
First, your function has no parameter to accept the -user switch that you use in the last line, so that's part of the problem. Another part is that functions really need to go ahead of any other code.  This would resolve that:

function SetSharePerm
{
   param($user)
   $shareName="\\acmeserv1\users$\$user"
   $userName="acme\$user"
   $SUBINACL='C:\Program Files (x86)\Windows Resource Kits\Tools\subinacl.exe'
   &$SUBINACL /share $shareName /grant="acme\Domain Admins"=F /grant=$userName=C |Out-Null

   }
$User="testuser"
SetSharePerm -user $user

Open in new window


You also need to escape the $ in your users$ share name with a `, so it would be users`$ instead of what you have.

Finally, you'll actually want to scrap the whole subinacl methodology and eventually learn to do ACLs directly with powershell. https://blogs.technet.microsoft.com/heyscriptingguy/2014/11/22/weekend-scripter-use-powershell-to-get-add-and-remove-ntfs-permissions/ explains how. What you're doing with this script is basically batch scripting in Powershell, which is awkward and error prone.
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Tim BallinAuthor Commented:
I took your advice and used Powershell to make the changes directly

function SetSharePerm
{
   param($user)
   $shareName="\\acmeserv1\users$\$user"
   $userName="acme\$user"
   Add-NTFSAccess -Path $shareName -account $userName -accessrights Modify

   }
$User="testuser"
SetSharePerm -user $user

Open in new window


Much more straightforward.  Thanks!
0
Tim BallinAuthor Commented:
Thanks for the direction Adam!
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Powershell

From novice to tech pro — start learning today.