asked on 9/3/2018

Help on my function to get a percentual from two values

Hello guys

I made this function to get the percentual from two value, but sometimes it works fine and sometimes it doesn't.

could you help me to ajust it?

Thanks a lot

alter Function  fn_PercentualDesconto (@Fullvalue float, @EndValue float)
  Returns Float
Begin 
	declare @v01 float;
	declare @v02 float;
	declare @v03 float;

        Set @v01=@Fullvalue 
	Set @v02=@EndValue 
	Set @v03=(@v01-@v02)
	Return 100- round((@v03 / @v01 ) * 100 , 2) 
End

Open in new window

Microsoft SQL Server 2008

Last Comment

Pavel Celba

9/5/2018

David Johnson, CD

9/3/2018

replace Return 100- round((@v03 / @v01 ) * 100 , 2)
with

Return 100.00- round((@v03 / @v01 ) * 100.00, 2)

Open in new window

100 is an integer

Pavel Celba

9/3/2018

If you are sure the @Fullvalue can never be 0 then calculate the result as

alter Function  fn_PercentualDesconto (@Fullvalue float, @EndValue float)
  Returns Float
Begin 
	Return round( (@EndValue / @Fullvalue) * 100, 2) 
End

Open in new window

If the possibility to have @Fullvalue = 0.0 exists then add one condition:

Return CASE WHEN @Fullvalue = 0.0 THEN 0.00 ELSE round( (@EndValue / @Fullvalue) * 100, 2) END

Open in new window

Or generate some error.

BTW, I don't understand your sentence "sometimes it works fine and sometimes it doesn't." . Could you provide some values which do not work?

hidrau

9/4/2018

ASKER

Hello Guys,

Thanks a lot for helping me

But Something wrong here, take a look:

When I do this:

select dbo.fn_PercentualDesconto(60, 54)

it returns me 90, it is wrong because it should be 10%

60 is my full value and I reached the 54 - The discount that I have was 6

6 on the 60 represents 10% and not 90%

thanks

Steve Bink

9/4/2018

        Set @v01=@Fullvalue 
	Set @v02=@EndValue 
	Set @v03=(@v01-@v02)
	Return 100- round((@v03 / @v01 ) * 100 , 2)

Open in new window

Executes as:

Set @v01 = 60
Set @v02 = 54
Set @v03 = (60-54)   <--  @v03=6
Return 100 - round (6 / 60 * 100, 2)   <-- return 100 - 10, or 90

Open in new window

Sounds like your code is doing exactly what you told it to.

hidrau

9/4/2018

ASKER

Steve Bink,

I think my code is not correct.

See:

I bought a book for $ 100, its normal price was $ 112.

When I was going to pay it, I just payed $100 becouse I had a discount on it.

It is not working at any way :(
What was my discount?

Select dbo.fn_PercentualDesconto(112, 100)

The function returned me: %89,29 and it is not correct, it should be 10% of discount.

ASKER CERTIFIED SOLUTION

Steve Bink

9/4/2018

THIS SOLUTION IS ONLY AVAILABLE TO MEMBERS.

View this solution by signing up for a free trial.

Members can start a 7-Day free trial and enjoy unlimited access to the platform.

See Pricing Options

Start Free Trial

hidrau

9/4/2018

ASKER

thanks guys for the help

Pavel Celba

9/5/2018

So you now understand percent value vs. percent discount hopefully.

You could simply use my formula slightly updated for discount calculation:

Return round( (1-(@EndValue / @Fullvalue)) * 100, 2)