Open a form for a new record

My preferred method is to pass the ClientID as the OpenArgs argument in the OpenForm method, and you can do the NewRecord aspect in the same step.  Furthermore, this method allows you to use the acDialog option in the WindowMode, which will prevent the code which follows the OpenForm method from running in the form that calls this form; I do this so that I can requery the current form after the popup closes.  It will also open the form in AddNew mode and pass it the value of the ClientID that you want to use for the new job.

So, to start with, the code you have above would be replaced with the following.  The first line will open your popup form in dialog mode (which will prevent that the rest of the code from running until the popup form is closed or hidden).  The way I generally do this is I open the popup form, and if the user actually adds a record, I simply hide that form when the user is done.  If they cancel the Add operation, then I close the form.  So the code below checks to see if the popup is still open and if so, it requeries the ClientJobs combo box and sets the value of that combo to the JobID which was just created, then it closes the popup.

docmd.OpenForm stDocName, acNormal, , , acFormAdd, acDialog, me.cbo_ClientID
if currentproject.allforms(stDocName).IsLoaded then
    me.cbo_ClientJobs.Requery
    me.cbo_ClientJobs = forms(stDocName).JobID
    docmd.close acform, stDocName
end if

Select all Open in new window

Then, in the Popup forms Load event, I add code which sets the value of the ClientID combo box based upon the value that was passed in the OpenArgs value of the OpenForm method.  I also call the AfterUpdate event of that combo box to fill in any other controls on the form which relate directly to the contact.

Private Sub Form_Load
    me.cbo_ClientID = NZ(me.OpenArgs, 0)
    Call cbo_ClientID_AfterUpdate
End Sub

Select all Open in new window

Finally, I set the ControlBox and CloseButton controls on the popup form to No, so the user has to click on either a 'Cancel' or 'Save' button on the form.  The code behind the Cancel button simply closes the form:

Private Sub cmd_Cancel_Click
    me.undo
    docmd.close acform, me.name
end sub

Select all Open in new window

while the code behind the 'Save' button checks to make sure all of the required fields are filled in, and if so, saves the record and closes the form.

Private Sub cmd_Save_Click
    if PassesChecks Then
        me.dirty = false
        me.visible = false
    endif
end sub

Select all Open in new window

The PassesChecks function (shown below is used to make sure that all of the required fields are filled in)

Private Function PassesChecks() as Boolean
    if trim(me.cbo_ClientID & "") = "" then
        msgbox "Select a client"
        me.cbo_ClientID.setfocus
        exit sub
    elseif trim(me.txt_JobTitle & "") = "" then
        msgbox "Enter a job title!"
        me.txt_JobTitle.Setfocus
        exit sub
'   elseif <= enter more criteria here to ensure that all required values for tbl_ClientJobs have been filled in
     
    else
          PassesChecks = true
    end if

End Function

Select all Open in new window