Troubleshooting part of SQL backup script.

Hi EE,

I have the following script to take backup and label them by date:

DECLARE @name VARCHAR(50) -- database name  
DECLARE @path VARCHAR(256) -- path for backup files  
DECLARE @fileName VARCHAR(256) -- filename for backup  
DECLARE @fileDate VARCHAR(20) -- used for file name

-- specify database backup directory
SET @path = 'F:\Temp\'  
 
EXEC xp_cmdshell 'FORFILES /p @path /s /m *.BAK /d -1 /c "CMD /C del /Q /F @FILE"'

-- specify filename format
SELECT @fileDate = CONVERT(VARCHAR(20),GETDATE(),112) 
 
DECLARE db_cursor CURSOR READ_ONLY FOR  
SELECT name 
FROM master.dbo.sysdatabases 
WHERE name NOT IN ('master','model','msdb','tempdb','test')  -- exclude these databases
 
OPEN db_cursor   
FETCH NEXT FROM db_cursor INTO @name   
 
WHILE @@FETCH_STATUS = 0   
BEGIN   
   SET @fileName = @path + @name + '_' + @fileDate + '.BAK'  
   BACKUP DATABASE @name TO DISK = @fileName 
   WITH COPY_ONLY

   FETCH NEXT FROM db_cursor INTO @name   
END   

 
CLOSE db_cursor   
DEALLOCATE db_cursor

Open in new window


The backups work fine however, the section to remove old DB backups isn't working
EXEC xp_cmdshell 'FORFILES /p @path /s /m *.BAK /d -1 /c "CMD /C del /Q /F @FILE"'

Open in new window


I have enabled XP_Cmdshell in the server config and checked to make sure the directory is correct.

How else would I troubleshoot this issue?

Any assistance is welcome.

Thank you.
ZackGeneral IT Goto GuyAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Paul NeralichBusiness OwnerCommented:
Hi Zack,

Which version of SQL Server are you running?

Is it possible to execute this command interactively on the server to see how it behaves?
FORFILES /p F:\Temp\ /s /m *.BAK /d -1 /c "CMD /C del /Q /F @FILE"

Open in new window


Or this just to see the file list of files that are getting queued for deletion:
FORFILES /p F:\Temp\ /s /m *.BAK /d -1 /c "CMD /C echo @FILE"

Open in new window



- Paul N.
0
Raja Jegan RSQL Server DBA & Architect, EE Solution GuideCommented:
Is there by any chance that you are using Share folder instead of "F:\Temp", if so, then deleting files on share path might be due to some permission issues..
And there is no need to use \ after "F:\Temp" and hence slightly modified your code, try it once and let us know the feedback..
FORFILES /p "F:\Temp" /s /m *.BAK /d -1 /c "cmd /c del @FILE"

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
ZackGeneral IT Goto GuyAuthor Commented:
Hi Paul,

I am using SQL Server 2017, I will attempt to run the ECHO command and let you know the outcome.

Hi Raja,

I will try your suggestion and see if this helps.

Thank you
0
IT Pros Agree: AI and Machine Learning Key

We’d all like to think our company’s data is well protected, but when you ask IT professionals they admit the data probably is not as safe as it could be.

ste5anSenior DeveloperCommented:
I am using SQL Server 2017 [..]

Open in new window

Then you should consider using a maintenance plan (scheduled) for this.
0
ZackGeneral IT Goto GuyAuthor Commented:
Hi Raja,

Thank you for the script that worked.

Cheers.
0
Raja Jegan RSQL Server DBA & Architect, EE Solution GuideCommented:
Welcome, Zack..
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Query Syntax

From novice to tech pro — start learning today.