Using a  time stamp correctly in sql

Fordraiders
Fordraiders used Ask the Experts™
on
Access vba

Using ian INSERT statement in vba.

What I need: sometimes the  " InProgress_or_Closed_at" value does not get inserted?
i'm i using the  "Now()"  correctly in the sql statement ?

Or is there a better way to write it to make sure a time stamp is posted correctly ?


ttt = Forms!dataentry.txtReOpened
                    strsql_sql = "INSERT INTO [dbo_t_nsc_trackcode_trans_time_entry](NSC_ID_Ref, [opened_at], InProgress_or_Closed_at)" & vbCrLf
                    strsql_sql = strsql_sql & "VALUES (" & Me.NSC_Id & ",'" & ttt & "' , now());"
                     CurrentDb.Execute strsql_sql, dbSeeChanges

Open in new window



Thanks
fordraiders
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
NorieAnalyst Assistant

Commented:
Does this work any better?
ttt = Forms!dataentry.txtReOpened
                    strsql_sql = "INSERT INTO [dbo_t_nsc_trackcode_trans_time_entry](NSC_ID_Ref, [opened_at], InProgress_or_Closed_at)" & vbCrLf
                    strsql_sql = strsql_sql & "VALUES (" & Me.NSC_Id & ",'" & ttt & "' , #" & Format(Now, "yyyy-mm-dd hh:mm:ss") &  "#);"
                     CurrentDb.Execute strsql_sql, dbSeeChanges

Open in new window

Most Valuable Expert 2015
Distinguished Expert 2018

Commented:
It should be OK. What about the other values?

Author

Commented:
"ttt"  is a time stamp also; but getting the value from a field on a form.
Ensure you’re charging the right price for your IT

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!

Most Valuable Expert 2015
Distinguished Expert 2018

Commented:
Yes, but are those values saved leaving the new timestamp empty?

Author

Commented:
Gustav, no sorry , no issues..
Most Valuable Expert 2015
Distinguished Expert 2018

Commented:
Ehh ..? so:

sometimes the  " InProgress_or_Closed_at" value does not get inserted?

means that nothing is inserted, or only that field is not inserted?
Fabrice LambertConsulting
Distinguished Expert 2017

Commented:
Hmm, what about setting a default value on the server for the InProgress_or_Closed_at column ?
Or a trigger setting the value ?
this way you won't have to worry about it in the front-end.

Also, keep in mind that with any date or time type columns, the value must be formated accordingly.

Author

Commented:
Gustav, The value   "Now()"  is not getting inserted into the field..at some point(but usually does).

Thanks
ste5anSenior Developer

Commented:
Just a comment:

A DATETIME column named  InProgress_or_Closed_at is semantic nonsense when used in a relational data model.

The normal usage here would be:

1) A clean relational data model. Thus you have a separate table to track that state. Were an existing row signals Is Closed and the row itself only consists of the key, the time stamp and maybe the user who closed it.

2) Using SQL NULL-value logic. The column would be named ClosedAt. When it is NULL, then the state is implicit In Progress. When a value is set, then it is implicit Closed.

Author

Commented:
Fabrice,
"Also, keep in mind that with any date or time type columns, the value must be formated accordingly."

So that is an interesting statement?

So would Norie's comment be correct ?

Thanks
fordraiders
Most Valuable Expert 2015
Distinguished Expert 2018
Commented:
No. Now() is a function that in SQL returns a Date vaiue, so nothing to format.

But you seem to face a timing issue.
Try this which should force a call to Date() and Time() before the insert:

ttt = Forms!dataentry.txtReOpened
strsql_sql = "INSERT INTO [dbo_t_nsc_trackcode_trans_time_entry](NSC_ID_Ref, [opened_at], InProgress_or_Closed_at)" & vbCrLf
strsql_sql = strsql_sql & "VALUES (" & Me.NSC_Id & ",'" & ttt & "' , (Date() + Time()));"
CurrentDb.Execute strsql_sql, dbSeeChanges

Open in new window

Dale FyeOwner, Dev-Soln LLC
Most Valuable Expert 2014
Top Expert 2010

Commented:
The following should work.  Note that with Access, you need to wrap literal date values like your ttt value in # (as in #11/16/2018#).  But because the Now() function returns a date, you should not need to wrap that in anything.
ttt = Forms!dataentry.txtReOpened
strsql_sql = "INSERT INTO [dbo_t_nsc_trackcode_trans_time_entry] (NSC_ID_Ref, [opened_at], InProgress_or_Closed_at) " _
           & "VALUES (" & Me.NSC_Id & ",#" & ttt & "# , Now());"
CurrentDb.Execute strsql_sql, dbSeeChanges

Open in new window

HTH
Dale

Author

Commented:
Thanks all

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial