<div>
I tried this but it errors after I supply the first response. I suspect because of the way I am trying to specify multiple parameters. 
 
Param([Parameter(Mandatory=$true)][string]$NameofKeyVaultResourceGroup) 
Param([Parameter(Mandatory=$true)][string]$NameofVirtualMachine) 
Param([Parameter(Mandatory=$true)][string]$NameOfKeyVault)
</div>

<div>
Try it like this. In addition to parameters, I changed the Set-AzureRmVMDiskEncryptionExtension call to use &quot;splatted&quot; &nbsp;arguments, that is, a hash table with the arguments to pass. 
Easier to read than a long line. 

<pre><code class="code-10 nolinks" id="code-20-42740353-1">Param(
	[Parameter(Position=0, Mandatory=$true, HelpMessage=&quot;The name of the Resource Group&quot;)]
	[string]$RgName,
	[Parameter(Position=0, Mandatory=$true, HelpMessage=&quot;The name of the VM&quot;)]
	[string]$VmName,
	[Parameter(Position=0, Mandatory=$true, HelpMessage=&quot;The name of the KeyVault&quot;)]
	[string]$KeyVaultName
)
$keyVault = Get-AzureRmKeyVault -VaultName $KeyVaultName -ResourceGroupName $RgName
$splat = @{
	ResourceGroupName = $RgName
	VMName = $vmName
	DiskEncryptionKeyVaultUrl = $keyVault.VaultUri
	DiskEncryptionKeyVaultId = $keyVault.ResourceId
}
Set-AzureRmVMDiskEncryptionExtension @splat
</code></pre>
</div>

<div>
Hello ObDa, your script did work, thank you very much. I realised I had left one variable out of the script I uploaded. Rather than come straight back here and ask for help I have spent the last hour trying to get it to work. But no luck. The updated script is here, and just below is my effort to amend the one you did for me. Sorry for being a pain, could you possibly make the amendment for me? 
 

<pre><code class="code-10 nolinks" id="code-20-42740402-1"> # Name of KeyVault Resource Group
 $rgName = '';

 # Name of VM Resource Group
 $VirtualMachineResourceGroupName = ''

 # Name of Virtual Machine
 $vmName = '';

 # Name of the KeyVault
 $KeyVaultName = '';

 # The KeyVault Name within the the Resource Group
 $KeyVault = Get-AzureRmKeyVault -VaultName $KeyVaultName -ResourceGroupName $rgname;

 # Keyvault name combined with the Keyvault URI
 $diskEncryptionKeyVaultUrl = $KeyVault.VaultUri;


 $KeyVaultResourceId = $KeyVault.ResourceId;

 #Set encryption
 Set-AzureRmVMDiskEncryptionExtension -ResourceGroupName $VirtualMachineResourceGroupName -VMName $vmName -DiskEncryptionKeyVaultUrl $diskEncryptionKeyVaultUrl -DiskEncryptionKeyVaultId $KeyVaultResourceId;
</code></pre>
 
######################################################################### 
 

<pre><code class="code-10 nolinks" id="code-20-42740402-2">Param (
[Parameter(Mandatory=$true)][string]$NameofKeyVaultResourceGroup,
[Parameter(Mandatory=$true)][string]$NameofVirtualMachine,
[Parameter(Mandatory=$true)][string]$NameOfKeyVault,
[Parameter(Mandatory=$true)][string]$NameofVMResourceGroup

)

 # The KeyVault Name within the the Resource Group
 $KeyVault = Get-AzureRmKeyVault -VaultName $KeyVaultName -ResourceGroupName $rgname;

 # Keyvault name combined with the Keyvault URI
 $diskEncryptionKeyVaultUrl = $KeyVault.VaultUri;


 $KeyVaultResourceId = $KeyVault.ResourceId;

 #Set encryption
 Set-AzureRmVMDiskEncryptionExtension -ResourceGroupName $VirtualMachineResourceGroupName -VMName $vmName -DiskEncryptionKeyVaultUrl $diskEncryptionKeyVaultUrl -DiskEncryptionKeyVaultId $KeyVaultResourceId;
</code></pre>
</div>

Jay Thomas

IT Professional

Albert Widjaja

<div>
Absolutely brilliant! &nbsp;Going to look at it side by side see if I can't learn something here. Thank you very much!
</div>

<div>
For the sake of completeness and full disclosure: you seem to have noticed that there was a comma missing after the first argument, and one too many after the last (changed the order; one of those last-second things). 
In case anybody else stumbles over this, here's the corrected version: 

<pre><code class="code-10 nolinks" id="code-20-42740433-1">Param(
	[Parameter(Position=0, Mandatory=$true, HelpMessage=&quot;The name of the KeyVault&quot;)]
	[string]$KVName,
	[Parameter(Position=1, Mandatory=$true, HelpMessage=&quot;Name of KeyVault Resource Group&quot;)]
	[string]$KVResourceGroup,
	[Parameter(Position=2, Mandatory=$true, HelpMessage=&quot;Name of Virtual Machine&quot;)]
	[string]$VMName,
	[Parameter(Position=3, Mandatory=$true, HelpMessage=&quot;Name of VM Resource Group&quot;)]
	[string]$VMResourceGroup
)
$keyVault = Get-AzureRmKeyVault -VaultName $KVName -ResourceGroupName $KVResourceGroup
$splat = @{
	ResourceGroupName = $VMResourceGroup
	VMName = $VMName
	DiskEncryptionKeyVaultUrl = $keyVault.VaultUri
	DiskEncryptionKeyVaultId = $keyVault.ResourceId
}
Set-AzureRmVMDiskEncryptionExtension @splat
</code></pre>
</div>

<div>
<div class="content wysiwyg-content">
Hi all, 
 
I have a small PS script which i downloaded to encrypt VMs which works just fine. I have defined variables which work. I'd like not to have to hardcode the variables, instead, when I run the script I'd like to be asked to input them. I know I can do this with parameters but find the search results confusing as there appears to be several types of parameter types. Also, the command at the bottom of the script would surely fail because it is still looking for the variables. Is this a big job to accomplish? Thanks you for looking. 
 
########################################### 
$rgName = 'MySecureRg'; 
&nbsp;$vmName = 'MySecureVM'; 
&nbsp;$KeyVaultName = 'MySecureVault'; 
&nbsp;$KeyVault = Get-AzureRmKeyVault -VaultName $KeyVaultName -ResourceGroupName $rgname; 
&nbsp;$diskEncryptionKeyVaultUrl = $KeyVault.VaultUri; 
&nbsp;$KeyVaultResourceId = $KeyVault.ResourceId; 
 
&nbsp;Set-AzureRmVMDiskEncryptionExtension -ResourceGroupName $rgname -VMName $vmName -DiskEncryptionKeyVaultUrl $diskEncryptionKeyVaultUrl -DiskEncryptionKeyVaultId $KeyVaultResourceId; 
 
##############################################
</div>
</div>

Hi all,

I have a small PS script which i downloaded to encrypt VMs which works just fine. I have defined variables which work. I'd like not to have to hardcode the variables, instead, when I run the script I'd like to be asked to input them. I know I can do this with parameters but find the search results confusing as there appears to be several types of parameter types. Also, the command at the bottom of the script would surely fail because it is still looking for the variables. Is this a big job to accomplish? Thanks you for looking. 

###########################################
$rgName = 'MySecureRg';
 $vmName = 'MySecureVM';
 $KeyVaultName = 'MySecureVault';
 $KeyVault = Get-AzureRmKeyVault -VaultName $KeyVaultName -ResourceGroupName $rgname;
 $diskEncryptionKeyVaultUrl = $KeyVault.VaultUri;
 $KeyVaultResourceId = $KeyVault.ResourceId;

 Set-AzureRmVMDiskEncryptionExtension -ResourceGroupName $rgname -VMName $vmName -DiskEncryptionKeyVaultUrl $diskEncryptionKeyVaultUrl -DiskEncryptionKeyVaultId $KeyVaultResourceId;

##############################################

Convert PS variables to Parameters

Windows PowerShell is a task automation and configuration management framework from Microsoft, consisting of a command-line shell and associated scripting language built on the .NET Framework. PowerShell provides full access to the Component Object Model (COM) and Windows Management Instrumentation (WMI), enabling administrators to perform administrative tasks on both local and remote Windows systems as well as WS-Management and Common Information Model (CIM) enabling management of remote Linux systems and network devices.