We help IT Professionals succeed at work.

I need form to close after an email is sent.

82 Views
Last Modified: 2019-02-14
Access doesn't execute DoCmd.Close to close the form after an email is sent.

Here's my entire code:

Private Sub Command799_Click()

Me.Dirty = False
    
If IsNull(Me.txtChargeCode.Value = True) And Me.cboMancamp.Value > 0 Then

        MsgBox "You must enter an AFE, Work Order, or Cost Center", vbOKOnly, "CHARGE CODE REQUIRED"

Else

If Me.cboMancamp.Value > 0 And IsNull(Me.txtStartDate.Value = True) Then

        MsgBox "You must enter an arrivial and check-out date", vbOKOnly, "LODGING DATES REQUIRED"

Else

If Me.cboMancamp.Value > 0 And IsNull(Me.txtEndDate.Value = True) Then

        MsgBox "You must enter an arrivial and check-out date", vbOKOnly, "LODGING DATES REQUIRED"

Else

DoCmd.RunCommand acCmdSaveRecord

Dim strBody As String
Dim strEmail As String
Dim strSubject As String
Dim objOutlook As Object
Dim objMailItem As Object
Const olMailItem As Integer = 0
Set objOutlook = CreateObject("Outlook.Application")
Set objMailItem = objOutlook.CreateItem(olMailItem)
    
On Error GoTo err_Error_handler

strEmail = [TO_Group]
strCc =  [CC_GROUP]
strSubject = "Field Visit Booking (Request ID# " & Me.FieldVisitBookingID & ") For " & txtContactName & " Starting " & Me.txtStartDate & " Finishing " & Me.txtEndDate
strBody = "<IMG alt='' hspace=0 src='L:\SharedData\Harrison\Midstream\ACIST\Support Files\Graphics\OPEN_email header-02.jpg' align=baseline border=0> <br>" & _
    "<br><br><font face=Calibri style=font-size:14pt;>All,<br><br> " & "" & _
    "A representative from " & Me.txtCompanyFullName & ", " & Me.txtContactName & ", (" & Me.txtContactMobile & ") will be visiting the field between <b>" & Me.txtStartDate & "</b> and <b>" & Me.txtEndDate & "</b>.  " & _
    "We would like to book them at the " & Me.cboMancamp & " and charge to <b>" & txtChargeCode & "</b>.<br /> " 

                  

objMailItem.SentOnBehalfOfName = strFro
objMailItem.To = strEmail
objMailItem.CC = strCc
objMailItem.Subject = strSubject
objMailItem.Importance = olImportanceHigh
objMailItem.HTMLBody = strBody
objMailItem.BodyFormat = olFormatHTML
objMailItem.Attachments.Add ("L:\test.pdf")
objMailItem.Display
 Set objOutlook = Nothing
 Set objMailItem = Nothing

exit_Error_handler:
 On Error Resume Next
 Set objOutlook = Nothing
 Set objMailItem = Nothing
 Exit Sub
 
err_Error_handler:
 Select Case Err.Number
  Case 287
   MsgBox "Canceled by user.", vbInformation
  Case Else
   MsgBox "Error " & Err.Number & " " & Err.Description
 End Select

Resume exit_Error_handler

DoCmd.Close acForm, "FieldVisitBookingEntryF"

End If
End If
End If
End Sub

Open in new window


The code executes perfectly to run the email, but doesn't close the form afterwards.  Thanks.
Comment
Watch Question

Shaun KlineLead Software Engineer
CERTIFIED EXPERT

Commented:
For your IF statements, if you do not want the user to continue, use the Exit Sub in the IF, and then End IF:
If IsNull(Me.txtChargeCode.Value = True) And Me.cboMancamp.Value > 0 Then
        MsgBox "You must enter an AFE, Work Order, or Cost Center", vbOKOnly, "CHARGE CODE REQUIRED"
        Exit Sub
End If

Open in new window


You have a jump point (line) for the error handler, but you do not have an On Error Goto statement at the beginning of the subroutine.

Finally, the Close Statement occurs after a Resume statement with a jump point (line) which prevents the close statement from running.
John TsioumprisSoftware & Systems Engineer
CERTIFIED EXPERT
Distinguished Expert 2019

Commented:
The Docmd.Close exists only in the Error Handler which is never reached because of the Exit Sub mentioned by the other Expert...an idea would be to extract the code to a function that returns a boolean ...if everything went fine..then Docmd.Close ...else report back what went wrong

Author

Commented:
So is this what I need to do?

Me.Dirty = False
    
If IsNull(Me.txtChargeCode.Value = True) And Me.cboMancamp.Value > 0 Then

        MsgBox "You must enter an AFE, Work Order, or Cost Center", vbOKOnly, "CHARGE CODE REQUIRED"

Else

If Me.cboMancamp.Value > 0 And IsNull(Me.txtStartDate.Value = True) Then

        MsgBox "You must enter an arrivial and check-out date", vbOKOnly, "LODGING DATES REQUIRED"

Else

If Me.cboMancamp.Value > 0 And IsNull(Me.txtEndDate.Value = True) Then

        MsgBox "You must enter an arrivial and check-out date", vbOKOnly, "LODGING DATES REQUIRED"

Else
Exit Sub
End If
End If
End If

DoCmd.RunCommand acCmdSaveRecord

Open in new window

Author

Commented:
John, how do I change the code below to trigger a close?

exit_Error_handler:
 On Error Resume Next
 Set objOutlook = Nothing
 Set objMailItem = Nothing
 Exit Sub
 
err_Error_handler:
 Select Case Err.Number
  Case 287
   MsgBox "Canceled by user.", vbInformation
  Case Else
   MsgBox "Error " & Err.Number & " " & Err.Description
 End Select

Resume exit_Error_handler

DoCmd.Close acForm, "FieldVisitBookingEntryF"

Open in new window

Lead Software Engineer
CERTIFIED EXPERT
Commented:
This one is on us!
(Get your first solution completely free - no credit card required)
UNLOCK SOLUTION

Author

Commented:
Ohhhhhhhhh....   Thanks!

Author

Commented:
I was thinking the last action would need to happen at the bottom without thinking about how it was actually executing.  Thanks for correcting that.  Your code change solution worked perfectly!  Thanks so much!

Gain unlimited access to on-demand training courses with an Experts Exchange subscription.

Get Access
Why Experts Exchange?

Experts Exchange always has the answer, or at the least points me in the correct direction! It is like having another employee that is extremely experienced.

Jim Murphy
Programmer at Smart IT Solutions

When asked, what has been your best career decision?

Deciding to stick with EE.

Mohamed Asif
Technical Department Head

Being involved with EE helped me to grow personally and professionally.

Carl Webster
CTP, Sr Infrastructure Consultant
Empower Your Career
Did You Know?

We've partnered with two important charities to provide clean water and computer science education to those who need it most. READ MORE

Ask ANY Question

Connect with Certified Experts to gain insight and support on specific technology challenges including:

  • Troubleshooting
  • Research
  • Professional Opinions
Unlock the solution to this question.
Join our community and discover your potential

Experts Exchange is the only place where you can interact directly with leading experts in the technology field. Become a member today and access the collective knowledge of thousands of technology experts.

*This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.

OR

Please enter a first name

Please enter a last name

8+ characters (letters, numbers, and a symbol)

By clicking, you agree to the Terms of Use and Privacy Policy.