Laurence Martin
asked on
Can't nest InStr in a Left function
Why doesn't this expression work in an Access Query?
Postcode 1: Left(Trim([Clients].[Postc ode]),InSt r(1,[Clien ts].[Postc ode]," ")-1)
I am getting an error that the expression is too complex.
If I put the InStr in a column of it's own and the Left with a constant for the length, they both work.
What I need to do is show the first part of the postcode. In the UK we have postcodes (zipcodes) that have a space in the middle eg: NW1 4FS or B1 2GT or WC1Y 3CE.
Is there another way to parse the string?
Could it be data related? There are some postcode fields that are empty or don't have a space
Postcode 1: Left(Trim([Clients].[Postc
I am getting an error that the expression is too complex.
If I put the InStr in a column of it's own and the Left with a constant for the length, they both work.
What I need to do is show the first part of the postcode. In the UK we have postcodes (zipcodes) that have a space in the middle eg: NW1 4FS or B1 2GT or WC1Y 3CE.
Is there another way to parse the string?
Could it be data related? There are some postcode fields that are empty or don't have a space
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
It seems that the whole query is too complex and this just pushes it over the edge. It has a massive From clause with lots of outer joins.
If I create a second query on the main one and add the calculated field then it works.
However, Jim's solution is better and so I'll build the IIf too.
Thanks
If I create a second query on the main one and add the calculated field then it works.
However, Jim's solution is better and so I'll build the IIf too.
Thanks
Try this, it should protect you from most problems with that field (blank, no embeded space, etc).
»bp
Postcode1:IIF(Trim([Clients].[Postcode])<>"",IIF(InStr(Trim([Clients].[Postcode])," ")>0,Left(Trim([Clients].[Postcode]),InStr(Trim([Clients].[Postcode])," ")-1),[Clients].[Postcode]),[Clients].[Postcode])
»bp
This appends a space to the right of the [PostCode] to ensure that every record will have a value returned by the Instr( ) function.
I then take everything including to the left of that first space using the Left() function and then trim the spaces.
I then take everything including to the left of that first space using the Left() function and then trim the spaces.
PostCode1:TRIM(Left([Clients].[PostCode] & " ", instr([Clients].[PostCode] & " ", " "))
This ensures that Trim will work, because there is no chance that a NULL will be processed.
That's a great approach. Get's rid of the IIF() to.
Jim.
Jim.
Thanks, Jim. I use this approach alot when using instr() or instrrev(). It generally takes some thought to get it right, but once I do, it generally works like a charm.
Dale
Dale
I guess the only note on that clever approach is that NULL values become "empty strings" in the process. That might be a good thing, or a bad thing, depending on the use case.
»bp
»bp
Bill,
True.
True.
Open in new window