Link to home
Start Free TrialLog in
Avatar of Dolamite Jenkins
Dolamite JenkinsFlag for United States of America

asked on

Coldfusion The tag <cfloop>, on line 17, column 2, requires an end tag.

error code ... according to the tutorial everything is correct I can't find the error (https://coldfusion.adobe.com/2017/11/bulk-inserting-data/) ... can anyone help first time using cold fusion
The <cfloop> tag requires an end tag to nest within <cfquery>, which began on line 12, column 2.
The CFML compiler was processing:

The body of a cfquery tag beginning on line 12, column 2.
The body of a cfquery tag beginning on line 12, column 2.
 
The error occurred in D:/home/semsreports.net/wwwroot/GPS_Action_page.cfm: line 17
15 :  values gps_id,unit_assigned,event,date,crew_one,crew_two
16 : 
17 : <cfloop from="1" to="#arraylen(users)#" index="u"> 
18 :  <cfif u NEQ 1>,</cfif>
19 :  (

Open in new window


Action page
 
<cfset gps_id = FORM["GPS_ID[]"]>
<cfset  unit_assigned = FORM["Unit_assigned[]"]>
<cfset event = FORM["event[]"]>
<cfset date = FORM["Date[]"]>
<cfset gps_id = FORM["GPS_ID[]"]>
<cfset crew_one = FORM["crew_one[]"]>
<cfset crew_two = FORM["crew_two[]"]>
<cfset comments = FORM["comments[]"]>



<cfquery datasource="xxxxxx " name="insert_gps_data">
 
 insert into gpstable  (GPS_ID,Unit_asssign, event, Date, crew_one,crew_two)
 values gps_id,unit_assigned,event,date,crew_one,crew_two

<cfloop from="1" to="#arraylen(users)#" index="u"> 
 <cfif u NEQ 1>,</cfif>
 (
 <cfqueryparam cfsqltype="cf_sql_varchar" value="#insert_gps_data[u].GPS_ID#">,
 <cfqueryparam cfsqltype="cf_sql_varchar" value="#insert_gps_data[u].Unit_assigned#">,
 <cfqueryparam cfsqltype="cf_sql_varchar" value="#insert_gps_data[u].event#">,
 <cfqueryparam cfsqltype="cf_sql_varchar" value="#insert_gps_data[u].Date#">,
 <cfqueryparam cfsqltype="cf_sql_varchar" value="#insert_gps_data[u].crew_one#">,
 <cfqueryparam cfsqltype="cf_sql_varchar" value="#insert_gps_data[u].crew_twot#">
 )
 </cfquery>
</cfloop>

Open in new window


page that feeds action page
[code]<script>
var ct = 1;
function new_link()
{
      ct++;
      var div1 = document.createElement('div');
      div1.id = ct;
      // link to delete extended form elements
      var delLink = '<div style="text-align:right;margin-right:65px"><a href="javascript:delIt('+ ct +')">Del</a></div>';
      div1.innerHTML = document.getElementById('newauth').innerHTML + delLink;
      document.getElementById('newlink').appendChild(div1);
}
// function to delete the newly added set of elements
function delIt(eleId)
{
      d = document;
      var ele = d.getElementById(eleId);
      var parentEle = d.getElementById('newlink');
      parentEle.removeChild(ele);
}
</script>

<style>
   #newlink {width:600px}
</style>
<form method="post" action="GPS_Action_page.cfm">
<div id="newlink">
<div>
<table border=0>
      
      
      <tr>
            
            <td> GPS ID: </td>
            <td>
                  <input type="text" name="GPS_ID[]" value="" validate='YES'>GPS ID <font size = -1 color = red>Required</font>
                  <br>
                  <input type="Text" name="Unit_assigned[]" value="" validate="YES">Unit Assigned<font size = -1 color = red>Required</font>
                  <br>
                  <input type="text" name="event[]" value=<cfoutput>#form.Event_Name#</cfoutput> validate="YES">Event<font size = -1 color = red>Required</font>  
                  <br>
                  <input type="Text" name="Date[]" value=<cfoutput>#form.Date#></cfoutput><font size = -1 color = red>Required</font>
                  <br>
                  <input type="text" name="crew_one[]" value="" validate="YES">Crew Member 1<font size = -1 color = red>Required</font>
                  <br>
                  <br>
                  <input type="text" name="crew_two[]" value="" validate="NO">Crew Member 1<font size = -1 color = red>Required</font>  
            </td>
      </tr>
      <tr>
            <td> Special Notesw: </td>
            <td>  <textarea name="comments[]" cols="50" rows="5" >
ASKER CERTIFIED SOLUTION
Avatar of _agx_
_agx_
Flag of United States of America image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
Avatar of Dolamite Jenkins

ASKER

thank you and thank you for explaining it to me as well ... have a great day
You're welcome. If you have any problems extracting the form field values, feel free to open another thread.