public static bool EstablishLocConnection(cDBCS cs)
{
//declare local variables
string s1 = cs.Server;
string s3 = cs.User;
string s4 = cs.PW;
string s2 = cs.Catalog;
string StrConnectString = null;
g_conn = new ADODB.Connection();
try
{
StrConnectString = "Provider=SQLOLEDB;" + "Data Source= " + s1 + ";Initial Catalog=" + s2;
g_conn.Open(StrConnectString, s3, s4);
if ((g_conn.State) != Convert.ToInt32(ADODB.ObjectStateEnum.adStateOpen))
{ return false; }
else
{ return true; }
}
catch (Exception ex)
{
MessageBox.Show("Estiblish Remote Database Connection caused error " + ex.Message);
return false;
}
}
This is one of my insert function to store data to the databasepublic long InsertRotorSID(cPart r, ADODB.Connection objconn)
{
ADODB.Command objcmd = new ADODB.Command();
objcmd.ActiveConnection = objconn;
object objAffected;
objcmd.CommandText = "usp_InsertRotorRecord";
objcmd.CommandType = ADODB.CommandTypeEnum.adCmdStoredProc;
try
{
// Job Identification Number
objcmd.Parameters.Append(objcmd.CreateParameter("P1", ADODB.DataTypeEnum.adBigInt, ADODB.ParameterDirectionEnum.adParamInput, 0, r.JobID));
// Equipment Line Number
objcmd.Parameters.Append(objcmd.CreateParameter("P2", ADODB.DataTypeEnum.adInteger, ADODB.ParameterDirectionEnum.adParamInput, 0, r.Line));
// Login User Name
objcmd.Parameters.Append(objcmd.CreateParameter("P3", ADODB.DataTypeEnum.adVarChar, ADODB.ParameterDirectionEnum.adParamInput, 50, r.UserName));
// Returned Rotor Serail Number
objcmd.Parameters.Append(objcmd.CreateParameter("SN", ADODB.DataTypeEnum.adBigInt, ADODB.ParameterDirectionEnum.adParamOutput));
// Returned Database Generated Rotor Identification Number
objcmd.Parameters.Append(objcmd.CreateParameter("RID", ADODB.DataTypeEnum.adBigInt, ADODB.ParameterDirectionEnum.adParamOutput));
objcmd.Execute(out objAffected);
GO.PLC.SN = Convert.ToInt32(objcmd.Parameters["SN"].Value);
GO.PLC.DBR = Convert.ToInt32(objcmd.Parameters["RID"].Value);
objcmd = null;
GDCO.gRDB_Conn.Close();
return 0;
}
catch (Exception ex)
{
MessageBox.Show("Insert rotor serial number caused error " + ex.Message, "Insert New Rotor Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
return 1;
}
}
Do I need to clean-up my source code, for example use the Using Keyword so that it properly dispose the object when I close the connection?