Query Not Looping

please post sample data for tbl_answers_therapist  and tbl_answers
and what are you passing $_GET['id']? 

You have some issues in your code. Please try like this:

if($query->num_rows > 0){ 
    while ($cmsData = $query->fetch_assoc()) {
        echo '<p>'.$cmsData['therapist_id'].'</p>';
        echo '<p>'.$cmsData['therapist_name'].'</p>';
        echo '<img src="/resources/images/Therapist/' . $cmsData['photo'] . '" height="100px" width="100px" border="2">';  
        echo '<p>'.$cmsData['details'].'</p>';
    }
} else { 
    echo 'Content not found....'; 
}
mysqli_free_result($query);
mysqli_close($db); 

Select allOpen in new window

HTH,
Dan

table answers therapist
table answers
right now I am just passing it as a hard code. later it will be a variable

Hi Dan..that comes up blank..

The page for context...

<?php
ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);
error_reporting(E_ALL);

if(!empty($_GET['id'])){ 
    // Database configuration 
    $dbHost = 'localhost'; 
    $dbUsername = ''; 
    $dbPassword = ''; 
    $dbName = ''; 
     
    // Create connection and select database  
    $db = new mysqli($dbHost, $dbUsername, $dbPassword, $dbName); 
     
    if ($db->connect_error) { 
        die("Unable to connect database: " . $db->connect_error); 
    } 
    // Get content from the database 
   $query = $db->query("SELECT therapist_id,therapist_name,photo,details FROM tbl_answers_therapist
   JOIN tbl_answers USING(country,state)
   WHERE tbl_answers.client_id = {$_GET['id']} AND tbl_answers_therapist.status = 'Yes'
   LIMIT 3");
   if($query->num_rows > 0){ 
    while ($cmsData = $query->fetch_assoc()) {
        echo '<p>'.$cmsData['therapist_id'].'</p>';
        echo '<p>'.$cmsData['therapist_name'].'</p>';
        echo '<img src="/resources/images/Therapist/' . $cmsData['photo'] . '" height="100px" width="100px" border="2">';  
        echo '<p>'.$cmsData['details'].'</p>';
    }
} else { 
    echo 'Content not found....'; 
}
mysqli_free_result($query);
mysqli_close($db); 
    //if($query->num_rows > 0){ 
       // while ($cmsData = $query->fetch_assoc()); 
       // echo '<p>'.$cmsData['therapist_id'].'</p>';
      //echo '<p>'.$cmsData['therapist_name'].'</p>';
      //echo '<img src="/resources/images/Therapist/', $cmsData['photo'], '" height="100px" width="100px" border="2">';  
      ///echo '<p>'.$cmsData['details'].'</p>';
      //mysqli_free_result($query);

  //mysqli_close($db); 
    }else{ 
        echo 'Content not found....'; 
    } 
}else{ 
    echo 'Content not found....'; 
} 
?>

Select allOpen in new window

Please try this:

 $query = $db->query("SELECT therapist_id,therapist_name,photo,details FROM tbl_answers_therapist
   JOIN tbl_answers USING(country,state)
   WHERE tbl_answers.client_id = {$_GET['id']} AND tbl_answers_therapist.status = 'Yes'
   LIMIT 3");
   echo '<p>Number of results: ' . $query->num_rows . '</p>'
   if($query->num_rows > 0){

Select allOpen in new window

It should output how many results you got from your query. If it's 0, then blank is normal.

I guess your query logic is wrong...

based on data, I see this query should be used

SELECT *
  FROM tbl_answers_therapist t
  JOIN tbl_answers a on a.country=t.country and a.state=t.state and a.answer_id=t.answer_id
 WHERE a.client_id = 1 AND t.status = 'Yes'
 LIMIT 3;

Select allOpen in new window

Still blank

also, add this

echo $_GET['id']

to see whats the value of ID
maybe you dont get anything...

The query is returning only one record, the correct answer is 2 records.  That's the issue.  It should loop. I think.

https://arise.plus/MODALHELPER.html
Try it here. You will see one result

based on your data and query, it should return 1 not 2!

tha data you posted above does not show status column...
is is "Yes" for those 2 records? Maybe one of them is "No"

The status is yes for both.

sorry, I could not get your date schema...
please post full columns and data...

also, you are checking one country_id here
based on your data, query returns correct values...

add more data, update your data and make sure you have correct values
then run the queries...

can you echo

$query->num_rows 

before loop... is it 1 or 3?

I am trying to keep it simple.  Query is based on Country, State and Status.  That's it.  I really think that it is not looping through the records thus not displaying them.  Please correct me if I am wrong.  It should be two rows returning.

can you run these queries and post the values

select * from tbl_answers a

select * from tbl_answers_therapist t

select * from tbl_answers_therapist t where a.client_id = 316

it looks like just data issue to me... 

ok, what happens if you do not check number of rows but just loop

if($query->num_rows > 0){     while ($cmsData = $query->fetch_assoc()) {
        echo '<p>'.$cmsData['therapist_id'].'</p>';
        echo '<p>'.$cmsData['therapist_name'].'</p>';
        echo '<img src="/resources/images/Therapist/' . $cmsData['photo'] . '" height="100px" width="100px" border="2">';  
        echo '<p>'.$cmsData['details'].'</p>';
    }
} else {     echo 'Content not found....'; } 

Select allOpen in new window

>>>

while ($cmsData = $query->fetch_assoc()) {
        echo '<p>'.$cmsData['therapist_id'].'</p>';
        echo '<p>'.$cmsData['therapist_name'].'</p>';
        echo '<img src="/resources/images/Therapist/' . $cmsData['photo'] . '" height="100px" width="100px" border="2">';  
        echo '<p>'.$cmsData['details'].'</p>';
    }

Select allOpen in new window

Question.  Is the query set up tp loop?

can you try this code...

$query = "SELECT ...";
$result = mysqli_query($query);

if (mysqli_num_rows($result) == 0) {
   echo "Content not found...."
} else {
   while ($cmsData = mysqli_fetch_assoc($result)) {
      echo '<p>'.$cmsData['therapist_id'].'</p>';
      echo '<p>'.$cmsData['therapist_name'].'</p>';
      echo '<img src="/resources/images/Therapist/' . $cmsData['photo'] . '" height="100px" width="100px" border="2">';  
      echo '<p>'.$cmsData['details'].'</p>';
    }
}

Select allOpen in new window

I got above sample from here

mysqli_fetch_assoc

https://www.macs.hw.ac.uk/~hwloidl/docs/PHP/function.mysqli-fetch-assoc.html

I guess num_rows fetches all records to get the result...
so, loop only finds the last record... my guess...

Just tried it.  Blank.

Can you post a link? Looks like it may be a local issue, on your server.

NVM, found it.

So, for ID 316, you expected more than 1 result?

https://arise.plus/MODALHELPER.html
yes there are two records that meet that criteria

And the code for getContent.php  is still this?: https://www.experts-exchange.com/questions/29197904/Query-Not-Looping.html#a43178380 

the problem I think is that it's not looping.  I either get one record or no records depending on the code I run but the correct answer is two

If the loop was not working, then you would get NO result.
The problem is that your query returns 1 result. You can check that by printing $query->num_rows.

but why am I getting two results when I run the query alone?  confused on this.

You're sure you're running the query against the same tables?
When I replace 316 with 1 or 3 I get "Content not found..."

there are no records for 1 or three.  316 is the client I have set up for this.

i should get the same results whether I run the query inside or outside of the webpage

I am convinced that the answer i
lies in this part.  The SELECT works with any variation o the WHERE part.

if($query->num_rows > 0){ 
        $cmsData = $query->fetch_assoc(); 
        echo '<p>'.$cmsData['therapist_id'].'</p>';
      echo '<p>'.$cmsData['therapist_name'].'</p>';
      echo '<img src="/resources/images/Therapist/', $cmsData['photo'], '" height="100px" width="100px" border="2">';  
      echo '<p>'.$cmsData['details'].'</p>'; 
    }else{ 
        echo 'Content not found....'; 
    }

Select allOpen in new window

Hey David,

The code you've just posted will only ever retrieve one record, because you're only calling fetch_assoc() once. You did seem to have the code set up to loop correctly earlier on, but it looks like you may have changed it.

I would suggest you take a step back on this and do some very simple debugging. Something along these lines:

<?php
error_reporting(E_ALL);
ini_set('display_errors', 1);

require_once 'db.php';

$sql = <<< EOT
    SELECT therapist_id, therapist_name, photo, details FROM tbl_answers_therapist
    JOIN tbl_answers USING(country,state)
    WHERE tbl_answers.client_id = 316 AND tbl_answers_therapist.status = 'Yes'
    LIMIT 3
EOT;

$query = $db->query($sql);

$data= $query->fetch_all();

var_dump($data);

Select allOpen in new window

You may need to edit it to include your own DB connection, but it's a simple query/dump. It will show you exactly what data you're getting back from your query without all the other white noise.

Working on it.  Chris.  This is PDO? Correct?

Warning: Use of undefined constant DB_NAME - assumed 'DB_NAME' (this will throw an Error in a future version of PHP) in /home/audiodigz/public_html/THERAPIST/includes/pdo_connection.php on line 14

Warning: Use of undefined constant DB_SERVER - assumed 'DB_SERVER' (this will throw an Error in a future version of PHP) in /home/audiodigz/public_html/THERAPIST/includes/pdo_connection.php on line 14

Warning: Use of undefined constant DB_USER - assumed 'DB_USER' (this will throw an Error in a future version of PHP) in /home/audiodigz/public_html/THERAPIST/includes/pdo_connection.php on line 15

Warning: Use of undefined constant DB_PASS - assumed 'DB_PASS' (this will throw an Error in a future version of PHP) in /home/audiodigz/public_html/THERAPIST/includes/pdo_connection.php on line 15

Fatal error: Uncaught PDOException: SQLSTATE[HY000] [2005] Unknown MySQL server host 'DB_SERVER' (0) in /home/audiodigz/public_html/THERAPIST/includes/pdo_connection.php:15 Stack trace: #0 /home/audiodigz/public_html/THERAPIST/includes/pdo_connection.php(15): PDO->__construct('mysql:dbname=DB...', 'DB_USER', 'DB_PASS') #1 /home/audiodigz/public_html/getContent.php(5): require_once('/home/audiodigz...') #2 {main} thrown in /home/audiodigz/public_html/THERAPIST/includes/pdo_connection.php on line 15

Select allOpen in new window

Also the entire site was moved from audiodigz.com to arise.plus so I do not now why this is coming up?

OK. That's an issue with your DB connection. Also, you seem to be importing a PDO connection here, but all of your code in this question so far has been MySQLi  - I'm guessing that you're including the wrong DB connection file. You must have the right one somewhere otherwise NONE of the code you've previously posted in this question would work at all

Fatal error: Uncaught Error: Call to undefined method mysqli_result::fetch_all() in /home/audiodigz/public_html/getContent.php:28 Stack trace: #0 {main} thrown in /home/audiodigz/public_html/getContent.php on line 28 

THis is what I have...

<?php
ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);
error_reporting(E_ALL);

if(!empty($_GET['id'])){ 
    // Database configuration 
    $dbHost = 'localhost'; 
    $dbUsername = ''; 
    $dbPassword = ''; 
    $dbName = ''; 
     
    // Create connection and select database  
    $db = new mysqli($dbHost, $dbUsername, $dbPassword, $dbName); 
     
    if ($db->connect_error) { 
        die("Unable to connect database: " . $db->connect_error); 
    } 
    $sql = <<< EOT
    SELECT therapist_id, therapist_name, photo, details FROM tbl_answers_therapist
    JOIN tbl_answers USING(country,state)
    WHERE tbl_answers.client_id = 316 AND tbl_answers_therapist.status = 'Yes'
    LIMIT 3
EOT;

$query = $db->query($sql);

$data= $query->fetch_all();

var_dump($data);
   // Get content from the database 
   //$query = $db->query("SELECT therapist_id,therapist_name,photo,details FROM //tbl_answers_therapist
   //JOIN tbl_answers USING(country,state)
   //WHERE tbl_answers.client_id = {$_GET['id']} AND tbl_answers_therapist.status = 'Yes'
   //LIMIT 3");
   //if($query->num_rows > 0){ 
        //$cmsData = $query->fetch_assoc(); 
        //echo '<p>'.$cmsData['therapist_id'].'</p>';
      //echo '<p>'.$cmsData['therapist_name'].'</p>';
      //echo '<img src="/resources/images/Therapist/', $cmsData['photo'], '" height="100px" //width="100px" border="2">';  
      //echo '<p>'.$cmsData['details'].'</p>'; 
    //}else{ 
        //echo 'Content not found....'; 
    //}
 
}else{ 
    echo 'Content not found....'; 
} 
?>

Select allOpen in new window

For your own sanity - clean up your code - remove EVERYTHING that isn't related to debugging this problem - get rid of the GET check, get rid of all the commented code, get rid of the else statements - clean code is easy code !!

Okay...here we go
array(4) { ["therapist_id"]=> string(1) "1" ["therapist_name"]=> string(16) "Dr. Larry Nogood" ["photo"]=> string(8) "Man1.png" ["details"]=> string(61) "I am a good therapist 1. Hire me. You won't be disappointed." } array(4) { ["therapist_id"]=> string(1) "3" ["therapist_name"]=> string(14) "Dr. Scott Ford" ["photo"]=> string(11) "Woman10.png" ["details"]=> string(61) "I am a good therapist 3. Hire me. You won't be disappointed." }

Okay so we are getting two records!

Now I need to get rid of the cmsData part

while ($data = $query->fetch_assoc()) {
    //var_dump($data);
   echo '<p>'.$cmsData['therapist_id'].'</p>';
   echo '<p>'.$cmsData['therapist_name'].'</p>';
   echo '<img src="/resources/images/Therapist/', $cmsData['photo'], '" height="100px" width="100px" border="2">';  
   echo '<p>'.$cmsData['details'].'</p>'; 

Select allOpen in new window

CHRIS!  YOU DID IT AGAIN!!!!!!

Thank you so much Chris I appreciate you.

OK. Perfect. So now you know you have 2 records, so build your HTML back into your loop:

$sql = <<< EOT
    SELECT therapist_id, therapist_name, photo, details FROM tbl_answers_therapist
    JOIN tbl_answers USING(country,state)
    WHERE tbl_answers.client_id = 316 AND tbl_answers_therapist.status = 'Yes'
    LIMIT 3
EOT;

$query = $db->query($sql);

while ($data = $query->fetch_assoc()) {
    printf("<p>%s</p>", $data['therapist_id']);
    printf("<p>%s</p>", $data['therapist_name']);
    printf("<img src='/resources/images/Therapist/%s' height='100px' width='100px'>", $data['photo']);
    printf("<p>%s</p>", $data['details']);
}

Select allOpen in new window

Give that a go to check it's working as expected

Ah - we cross posted. Good effort. Glad you got it sorted.

Often, when things aren't going as expected, it pays to strip your code back to basics and build up from there - checking code off in bite sized chunks. It gives you much clearer picture of what's working and what's not.

Thank you Chris...

You're welcome David :)