Ansible Playbook mount CIFS, copy and run shell script

Thanks Simon! I am testing now…

Hi Simon, 

This is the latest revision. 

The error appears to be in '/home/ansible/ubuntuscript.yml': line 19, column 15, but may
be elsewhere in the file depending on the exact syntax problem. 

The line reference it's a little different in Visual Studio Code than here. The error complains about line 19 which is 

Any thoughts on how to should I define this? 

Thank you so much! 

--- 

- hosts: all

  become: true

  tasks:

     - name: Join the machine if it is not already on the domain.

       become: yes 

       command: /opt/pbis/bin/domainjoin-cli join --ou OU=bolt,DC=ev,DC=nal,DC=com ev.nal.com dom xxxx

       no_log: True

     - name: Allow {{ reqUser }} to sudo, and validate the sudoers file before saving

       ansible.builtin.lineinfile:

           path: "/etc/sudoers.d/90-cloud-init-users"

           state: present

           mode: "0440"

           create: yes

           regexp: '^corp\\{{ reqUser }}'

           line: 'corp\\{{ reqUser }} ALL=(ALL) NOPASSWD: ALL'

           validate: /usr/sbin/visudo -cf %s

     - name: Mount network share

         mount:

         src: //auto_hq00cifs_ds01.orp.nal.com/auto_cifs_ds01/8/um/tu/

         path: /mnt

         fstype: cifs

         opts: 'username=admin@corp.nal.com,password=XXX'

         state: mounted

         become: true

     - name: Copy data

        copy:

           src: //auto_hq00cifs_ds01.orp.nal.com/auto_cifs_ds01/8/um/tu/install_tanium_ubuntu.sh

           dest: /opt/ 

           mode: "0755"

           remote_src: yes

     - name: "Execute the script"

       command: bash /opt/install_tanium_ubuntu.sh

       register: version

The "mount:" on line 19 needs to be indented the same as the "name:" on 18 (i.e. the "m" immediately below the "n"). The "src:", "path:" etc on the following lines are the parameters of the "mount:" so should be left where they are, indented 2 spaces more than the repositioned "mount:".

I'm doing this on my phone on a walk, so may be misreading it!

Thanks Simon! I made the change and testing now.

That seemed to have worked, however the playbook errors out with 

TASK [Mount network share] *****************************************************,fatal: [tan3]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (mount) module: become. Supported parameters include: src, path (name), dump, passno, fstab, boot, fstype, state, backup, opts."},,PLAY RECAP *********************************************************************,tan3 : ok=3 changed=2 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0

Sorry, missed that. "become:" is a feature of the task itself, so must be at the same indentation as "name:" and "mount:".

Ok, "become" it's now indented this way... testing now. 

- name: Mount network share
  mount:
         src: //cifs_ds01.orp.nal.com/auto_cifs_ds01/8/ium/tu/
         path: /mnt
         fstype: cifs
         opts: 'username=dmin@op.nal.com,password=XXX'
         state: mounted
  become: true

Select allOpen in new window

Thanks!

Looks like I am still getting the error:

TASK [Mount network share] *****************************************************,fatal: [tan6]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (mount) module: become. Supported parameters include: src, path (name), dump, passno, fstab, boot, fstype, state, backup, opts."},,PLAY RECAP *********************************************************************,tan6 : ok=3 changed=2 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0

That's odd. Are you sure you saved the updated version? Do you have any tabs in the files (though Ansible would usually tell you if you'd mixed tabs and spaces)?

Let me double check the modify date for the yaml file. 

Looks like I might need to install CIFS-utils first?

 

sudo apt install cifs-utils

Select allOpen in new window

Maybe adding something like this?

tasks:

     - name: Execute command using the shell module 

       become: true 

       become_user: root

       shell: sudo apt install cifs-utils 

Yes, that looks like it is needed. Often a good idea to try a step manually first, before you automate it!

You have already become root, so no need for the sudo, but you do need a "-y"
     apt install -y cifs-utils

Ok, thanks, testing now...

Better would be to use the "package" module:

- name: Install cifs-utils to get the mount.cifs program
  package:
    name: cifs-utils
    state: present

Select allOpen in new window

That sounds much better, I've updated the play with that, fingers crossed! 

Also, as a bit of tidy-up, you have "become: true" at the top level, so don't need to add it to the individual tasks, and the default "become_user" is root so you don't have to specify that.

Thanks so much for pointing and explaining that out! 

This is weird, getting the following:

Unable to validate syntax for Playbook(s). Failed to execute script on host hq00ansvrap01. Error: [WARNING]: While constructing a mapping from /home/ansible/ubuntuscript.yml,
line 5, column 8, found a duplicate dict key (name). Using last defined value
only.
ERROR! conflicting action statements: package, state
The offending line appears to be:

tasks:
- name: Install cifs-utils to get the mount.cifs program
^ here 

Select allOpen in new window

Can you paste the lines around that bit, in a code block?

Sure, I just did. 

I meant the text of the playbook, It looks as though you have the same key at one level - one should probably be indented!

For example, the "name" line for the package to be managed must be indented 2 spaces more than the "package" key.

Does this look ok? 

The "become" and "mount" under "name: Mount network share" are in the wrong place again (move them left 2 spaces).

Also, in the "copy" section, you should replace

src: //auto_hq00cifs_ds01.orp.nal.com/auto_cifs_ds01/8/um/tu/install_tanium_ubuntu.sh

Select allOpen in new window

with

src: /mnt/install_tanium_ubuntu.sh

Select allOpen in new window

Or, miss out the "copy" tasks completely, and run the command as "bash /mnt/install_tanium_ubuntu.sh"

Sorry! For some reason the copy/paste sometimes doesn't seem to keep the spaces in place. I've updated post above. 

I have also change the src with your suggestion. 

Testing! 

Yes, copy-n-paste isn't always reliable!

Simon, thank you so much for the help, the teaching and the patience! :)